bump Rust #777
Merged
bump Rust #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Failure only on 32bit Windows... WTF.^^ |
Member
Author
|
I had to add some more special rules to allow I didn't bother doing this in full generality because hopefully @christianpoveda will have intptrcast finished sooner rather than later, and then we can talk about pretty much requiring that to be enabled to allow executing pre-main stuff... |
Member
Author
|
@oli-obk does this look good to you? |
oli-obk
reviewed
Jun 21, 2019
| err!(InvalidPointerMath) | ||
| } | ||
| } | ||
| Gt | Ge if left.is_ptr() && right.is_bits() => { |
Contributor
There was a problem hiding this comment.
I mean it doesn't really matter with int2ptr around the corner, but why is this not implemented commutatively?
Member
Author
There was a problem hiding this comment.
I didn't find a good way to do this without copying the code and, as you said, with int2ptr around the corner it just does not seem worth the effort.
Contributor
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to make sure rust-lang/rust#60341 doesn't break us on macOS (Rust CI does not test tools on macOS).