Add more missing math functions #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. I wasn't sure about the windows name for |
|
Oh also, if you want to try something more like https://github.com/RalfJung/miri/blob/6a0d092eaf3150a4ae2e509744c49d5cadc60efc/src/intrinsic.rs#L188 that'd be great. |
|
CI looks happy. @kennethbgoodin did you want to try to share the float input/output code some more? |
|
Yes I am. |
Add missing functions for atan2, cosh, sinh, and tan. Also add f32 calls and tests for cbrt and hypot.
kungfukennyg
force-pushed
the
foreign_math_functions
branch
from
985e463 to
46b6a3f
Compare
RalfJung
reviewed
Jun 14, 2019
|
Looks good except for the indentation. In the future, please don't force-push unless you are resolving conflicts with a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #667 add missing functions for
atan2,cosh,sinh, andtan. Also add f32 calls and tests forcbrtandhypot. Note that this does not make thenumcrates fully testable (ex: #770 )This could be further cleaned up by condensing the f32 and f64 variants of each function into the same match arm. Or we could reduce even more code duplication wrt reading/writing floats similar to how intrinsics does so here: https://github.com/RalfJung/miri/blob/6a0d092eaf3150a4ae2e509744c49d5cadc60efc/src/intrinsic.rs#L188