user-relevant span: if no frame is in a local crate, use topmost non-track_caller frame #4653
      
        
          +186
        
        
          −92
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Our logic for the user-relevant span ignores all frames that are in non-user-relevant crates. Unfortunately, if the stack consists entirely of frames from non-user-relevant crates, the result is something like this:
In other words, we fall back to the topmost frame of the stack. That's not great.
This adjusts the logic so that we instead fall back to the topmost non-track_caller frame. Only if we find no such frame do we use the topmost frame.
This is done by replacing the
is_user_relevant: boolwith auser_relevance: u8indicating how relevant the frame is. The current top relevant frame is the topmost frame with the highest relevance. The code that runs on push/pop is adjusted to incrementally update the topmost frame index with the new metric; this should only be marginally more expensive than what we did here before.r? @saethlin