Support f32/f64 in native function calls
#4650
Open
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to Miri! |
RalfJung
reviewed
Oct 27, 2025
src/shims/native_lib/mod.rs
Outdated
| } | ||
| ty::Float(FloatTy::F32) => { | ||
| let x = unsafe { ffi::call::<f32>(fun, libffi_args) }; | ||
| Scalar::from_f32(Single::from_bits(u128::from(x.to_bits()))) |
There was a problem hiding this comment.
Suggested change
| Scalar::from_f32(Single::from_bits(u128::from(x.to_bits()))) | |
| Scalar::from_f32(x.to_soft()) |
This should work after importing the ToSoft trait.
There was a problem hiding this comment.
Oh, I overlooked that.
My apologies -- I have corrected it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4642.
I would appreciate feedback on the following:
f32and another forf64-- but I later concluded that this might be redundant. If not, I am happy to reintroduce the second one;rustc_apfloat, and the only suitable solution I have found wasfrom_bits. I may have overlooked something, but going through the codebase, I did not find any other way to do this;to_bits()-> cast ->from_bits()) are bit-preserving, I do not think we need to worry about signaling NaNs here. Am I correct thinking this should not be problematic?Thank you in advance for your time and input!