Skip to content

Conversation

@RalfJung
Copy link
Member

It seems we have to set the message twice, unfortunately.

@rust-lang/miri what do you think?

Cc @Urgau

@RalfJung RalfJung force-pushed the triagebot-welcome branch from 4d9782f to 51a65bf Compare July 16, 2025 11:43
@RalfJung RalfJung force-pushed the triagebot-welcome branch from 51a65bf to b492882 Compare July 16, 2025 11:58
@oli-obk
Copy link
Contributor

oli-obk commented Jul 16, 2025

Do we even have the first message? We never auto assign reviewers

@RalfJung
Copy link
Member Author

RalfJung commented Jul 16, 2025 via email

@oli-obk oli-obk added this pull request to the merge queue Jul 16, 2025
Merged via the queue into rust-lang:master with commit d0886ef Jul 16, 2025
13 checks passed
@RalfJung RalfJung deleted the triagebot-welcome branch July 16, 2025 15:30
@Urgau
Copy link
Member

Urgau commented Jul 16, 2025

It seems we have to set the message twice, unfortunately.

Yeah, this is on purpose, we didn't wanted repos to have half custom/half default message.

I am hoping we cam have a welcome message even if we don't auto-assign

Yes, contrary to the default auto-assign message, the custom ones (that you just set here) are pretty much always triggered (modulo if there is a manual assignment r? in the PR description).

but the docs don't make that fully clear

Will make a note to improve them.


Btw, I noticed that in addition to the custom messages, you also have the contributing_url option set, which wasn't used before since there wasn't any message but now that there is one it will be used (if you don't want it, just remove it from the config).

@RalfJung
Copy link
Member Author

Yeah, this is on purpose, we didn't wanted repos to have half custom/half default message.

But one of them is dead weight for us because we are not using auto-assign, right?

Btw, I noticed that in addition to the custom messages, you also have the contributing_url option set, which wasn't used before since there wasn't any message but now that there is one it will be used (if you don't want it, just remove it from the config).

Ah, thanks for the heads-up! I'll wait to see how it looks for real... but the message already links to the same document so yeah we should probably remove it.

@RalfJung
Copy link
Member Author

Btw, can that message use markdown?

@Urgau
Copy link
Member

Urgau commented Jul 16, 2025

But one of them is dead weight for us because we are not using auto-assign, right?

Yeah, it is, I wonder if on triagebot side we should make the check a bit smarter by only requiring welcome-message (not the -no-reviewer variant) if auto-assign is enabled.

Btw, can that message use markdown?

Yes, absolutely, triagebot forwards the content as-is to GitHub, so you use whatever GitHub supports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants