Added a variadic argument helper #3968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohDeadfall
commented
Oct 13, 2024
RalfJung
reviewed
Oct 14, 2024
|
Should then I change other places where I find it going after?
Yes please do.
|
RalfJung
reviewed
Oct 14, 2024
RalfJung
reviewed
Oct 14, 2024
| id => { | ||
| throw_unsup_format!("can't execute syscall with ID {id}"); | ||
| op => { | ||
| throw_unsup_format!("can't execute syscall with number {op}"); |
There was a problem hiding this comment.
Suggested change
| throw_unsup_format!("can't execute syscall with number {op}"); | |
| throw_unsup_format!("syscall: unsupported syscall number {num}"); |
|
r=me after squashing. :) |
|
✌️ @YohDeadfall, you can now approve this pull request! If @RalfJung told you to " |
YohDeadfall
force-pushed
the
variadic-arg-helper
branch
from
7ef93eb to
3a8cbc2
Compare
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RalfJung, as you wished (: