Skip to content

Conversation

@DeSevilla
Copy link
Contributor

Fixes #3808, does not change any functionality

@RalfJung
Copy link
Member

RalfJung commented Sep 9, 2024

Thanks! I did a bunch more renaming to hopefully make things more consistent wrt file description vs file descriptor: the latter (of type i32) are now called fd_num. We should only use them in the outer layers of the shims anyway, internally in Miri everything should be file descriptions.

@bors r+

@bors
Copy link
Contributor

bors commented Sep 9, 2024

📌 Commit d484d25 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 9, 2024

⌛ Testing commit d484d25 with merge 297e957...

@bors
Copy link
Contributor

bors commented Sep 9, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 297e957 to master...

@bors bors merged commit 297e957 into rust-lang:master Sep 9, 2024
@bors bors mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename file_descriptor to file_description_ref

3 participants