Skip to content

Conversation

@tiif
Copy link
Member

@tiif tiif commented Aug 23, 2024

In epoll_ctl documentation, it is mentioned that:

EINVAL epfd is not an epoll file descriptor, or fd is the same as epfd, or the requested operation op is not supported by this interface.

So I added this EINVAL case for epfd == fd in epoll_ctl

Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for this code path

@tiif tiif requested a review from oli-obk August 24, 2024 10:14
@oli-obk
Copy link
Contributor

oli-obk commented Aug 24, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Aug 24, 2024

📌 Commit e50c832 has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 24, 2024

⌛ Testing commit e50c832 with merge a7c000f...

@bors
Copy link
Contributor

bors commented Aug 24, 2024

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing a7c000f to master...

@bors bors merged commit a7c000f into rust-lang:master Aug 24, 2024
@tiif tiif deleted the einval_ctl branch November 5, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants