Provenance forging for miri_pointer_name
          #2939
        
          
      
                
     Closed
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Shims to give
miri_pointer_namea tag in a non-hacky way that is compatible with currentUniqueexperiments as well as possible future GC developments.Previous way of naming an unreachable tag was to refer to the nth parent of a reachable tag. This is very unreliable in the presence of
-Zmiri-unique-is-uniquewhich changes the number of intermediate tags between reachable tags (unique.as_ptr()) and interesting tags (unique.ptr).A more reliable method is proposed here, with
miri_pointer_nameitself,This will provide the tools to easily solve the diagnostics aspect of the recent blocker for #2936