Skip to content

attempt to overwrite globally set build.rustc-wrapper #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2022
Merged

attempt to overwrite globally set build.rustc-wrapper #2430

merged 2 commits into from
Jul 24, 2022

Conversation

RalfJung
Copy link
Member

Hopefully fixes #2429

@RalfJung RalfJung mentioned this pull request Jul 23, 2022
Closed
@RalfJung RalfJung force-pushed the no-global-wrapper branch from 351b60c to f2da26f Compare July 23, 2022 23:49
@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jul 23, 2022

📌 Commit f2da26f has been approved by RalfJung

It is now in the queue for this repository.

bors added a commit that referenced this pull request Jul 23, 2022
@bors
Auto merge of #2430 - RalfJung:no-global-wrapper, r=RalfJung
e0d6e07 
attempt to overwrite globally set build.rustc-wrapper

Hopefully fixes #2429
@bors
Copy link
Contributor

bors commented Jul 23, 2022

⌛ Testing commit f2da26f with merge e0d6e07...

@bors
Copy link
Contributor

bors commented Jul 24, 2022

💔 Test failed - checks-actions

@RalfJung RalfJung force-pushed the no-global-wrapper branch from f2da26f to c68488c Compare July 24, 2022 00:10
@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jul 24, 2022

📌 Commit c68488c has been approved by RalfJung

It is now in the queue for this repository.

@RalfJung RalfJung force-pushed the no-global-wrapper branch from c68488c to cb0904b Compare July 24, 2022 00:18
@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jul 24, 2022

📌 Commit cb0904b has been approved by RalfJung

It is now in the queue for this repository.

@RalfJung RalfJung force-pushed the no-global-wrapper branch from cb0904b to 7267e0d Compare July 24, 2022 00:23
@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jul 24, 2022

📌 Commit 7267e0d has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 24, 2022

⌛ Testing commit 7267e0d with merge 8fdb720...

@bors
Copy link
Contributor

bors commented Jul 24, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 8fdb720 to master...

@bors bors merged commit 8fdb720 into rust-lang:master Jul 24, 2022
@RalfJung RalfJung deleted the no-global-wrapper branch July 24, 2022 01:14
@saethlin
Copy link
Member

saethlin commented Jul 24, 2022 •
edited
Loading

I think this PR broke the nextest support. cargo miri nextest list now does this:

   Compiling scratch v0.1.0 (/tmp/scratch)
    Finished test [unoptimized + debuginfo] target(s) in 0.10s
error: creating test list failed

Caused by:
  for `scratch::bin/scratch`, running command `/tmp/scratch/target/miri/x86_64-unknown-linux-gnu/debug/deps/scratch-8097932b18eafdc6 --list --format terse` failed to execute

Caused by:
  Permission denied (os error 13)

list is the first step of nextest run. Any crate with any test seems to work as a reproducer.

It looks like something, probably nextest, is now trying to execve one of the JSON files.

@RalfJung
Copy link
Member Author

RalfJung commented Jul 24, 2022 •
edited
Loading

Are you sure it was this change, not #2428, that broke nextest ?

Either way, please open an issue.

@RalfJung RalfJung mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setting rustc-wrapper in ~/.cargo/config break miri
3 participants
@RalfJung @bors @saethlin