fix comparing wide raw pointers #2336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
wide-ptr-compare
branch
2 times, most recently
from
0c48ba8 to
628f847
Compare
RalfJung
force-pushed
the
wide-ptr-compare
branch
from
628f847 to
6c8ad4a
Compare
|
Confirmed by @bjorn3 @JakobDegen we probably want this in the MIR semantics docs. |
|
@bors r+ |
|
📌 Commit 6c8ad4a has been approved by |
|
☀️ Test successful - checks-actions |
|
@RalfJung this seems more like something that should go in the reference, no? It's a language thing after all, not MIR specific. We can put it in the docs too of course, but I don't generally think we need to duplicate language semantics there |
|
It should be in the reference as well, yes. Some MIR binops are surprisingly subtle though so I think it should be there, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/rust#96169
However I am not sure if these are the correct semantics. Lexicographic comparison of the two wide ptr components?!? I'll wait for confirmation in that issue.