-
Notifications
You must be signed in to change notification settings - Fork 385
Use miri
inside the target directory used by rustc as Miri's target directory
#1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RLS does something here, did you check what it is the do? |
It is using Cargo as a git or path dependency. It's not using |
Yeah I agree your approach works better for Miri. Thanks for checking! |
(Another option is to use Cargo from crates.io. I assume that's not viable, because in the rust-lang/rust repository, it's not allowed to have two versions of |
Also cargo is a huge dependency, I much prefer what you did. :) |
Looking great, thanks a lot for taking care of this long-standing issue. :) |
📌 Commit e3fca9b has been approved by |
☀️ Test successful - checks-actions |
update miri Let's get rust-lang/miri#1842 shipped. :) Also fixes rust-lang#86863 Cc `@rust-lang/miri` r? `@ghost`
Resolves #1311.
This PR makes Miri use
miri
inside the rustc target directory as its target directory, by lettingcargo-miri
get the rustc target directory by callingcargo metadata
, appendmiri
to it, and pass it with--target-dir
to Cargo.Getting the rustc target directory accurately requires calling
cargo metadata
as far as I know, because thetarget-dir
can be set in config files in various places that are hard forcargo-miri
to find.I also considered https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#custom-named-profiles, but it looks like that requires adding
cargo-features = ["named-profiles"]
toCargo.toml
, which would be tricky forcargo-miri
: