add deallocation tracking #1334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @RalfJung |
RalfJung
reviewed
Apr 15, 2020
RalfJung
reviewed
Apr 15, 2020
|
Looks good, just some nits. :) |
RalfJung
reviewed
Apr 15, 2020
|
Please avoid merge commits in PRs, and rebase instead. |
RustyYato
force-pushed
the
track-dealloc
branch
from
229445f to
bc3e759
Compare
RustyYato
force-pushed
the
track-dealloc
branch
from
bc3e759 to
b77968e
Compare
|
cc @RalfJung Ok, I've made the changes you asked and cleaned up the history. I think this is good to go. |
|
Indeed I think so too, thank you. :) |
|
📌 Commit b77968e has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1314