error code E0080 is no longer printed with MIRI error message #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Nov 6, 2019
src/eval.rs
Outdated
| let mut err = struct_error(ecx.tcx.tcx.at(span), msg.as_str()); | ||
| let mut err = { | ||
| let new_tcx = ecx.tcx.tcx.at(span); | ||
| new_tcx.sess.struct_span_err(new_tcx.span, msg.as_str()) |
There was a problem hiding this comment.
Suggested change
| new_tcx.sess.struct_span_err(new_tcx.span, msg.as_str()) | |
| ecx.tcx.sess.struct_span_err(span, msg.as_str()) |
There was a problem hiding this comment.
yea, the old tcx.at dance was just because of the struct_error API, and is not really something that is relevant for struct_span_err
|
Thanks! @bors r+ |
|
📌 Commit e5675ab has been approved by |
bors
added a commit
that referenced
this pull request
Nov 6, 2019
error code E0080 is no longer printed with MIRI error message Thanks to help from @bjorn3, @RalfJung, and @oli-obk on issue #1035 , I fixed the miri code so that error code **E0080** is no longer printed out for MIRI evaluation errors. I tested my code in my Linux machine as below.  Remaining concern is whether the variable name `new_tcx` which I used is misleading or not. Fixes #1035
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to help from @bjorn3, @RalfJung, and @oli-obk on issue #1035 , I fixed the miri code so that error code E0080 is no longer printed out for MIRI evaluation errors. I tested my code in my Linux machine as below.
Remaining concern is whether the variable name
new_tcxwhich I used is misleading or not.Fixes #1035