"cargo miri test" ignores "required-features"

[alecmocatta]

cargo test compiles and runs only tests that aren't disabled via required-features = ["foo"] (or test = false) in Cargo.toml.

cargo miri test tries to compile and run all tests, resulting in either target `test_foo` in package `xyz` requires the features: `foo` or arbitrary errors from explicitly disabled tests.

A fix for this would probably check for the args --no-default-features --features="..." and --all-features, pass them to cargo_metadata::MetadataCommand, read Node::features, and then filter the targets returned by list_targets().

[RalfJung]

Thanks for the report!

The part about test = false is a duplicate of #700, which is blocked on oli-obk/cargo_metadata#114. So let's use this issue for the required-features problem, which I was not aware of.

Really the best thing would be if we didn't have to re-implement the entire binary selection of cargo, which is tracked separately in #739.