chore: share license information across the entire workspace #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping @michaelwoerister, since you're the person committing to this repository most recent :) |
michaelwoerister
approved these changes
May 27, 2024
|
Thanks, @weihanglo! Do we need a release for this to fix the rust-lang/rust issue? |
|
Yeah thanks @michaelwoerister! I would love to see new releases for fixing the rust-lang/rust#125465, though it might also require some old version to get released, as well as publish some new packages. I am still working on improving the infrastructure to make it easier to release new versions (e.g. #228). I'll let you know what are needed to publish once I figure them out. |
|
Yeah, we might need to backport some of these changes to 10.1.x and 9.2.x if anything other than measureme itself is referenced from the Rust repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was found during the course of vendoring rustc-perf in rust-lang/rust repo: rust-lang/rust#125465 (comment).
Some packages don't have a license field defined and failed license-check in tidy.
The symlinks are also essential. When
cargo packagecreate a.cratetarball, those licenses should be included in each package.If sharing workspace information is something we want, I could include more in follow-ups.