For generalized handling of counters, we've been serializing this as counter.units in the JSON:

Lines 148 to 158 in 1d904b7

    
           Counter::WallTime(_) => ( 
        
               WallTime::NAME, 
        
               r#"[["ns", 1], ["μs", 1000], ["ms", 1000000], ["s", 1000000000]]"#, 
        
           ), 
        
           Counter::Instructions(_) => (Instructions::NAME, r#"[["instructions", 1]]"#), 
        
           Counter::InstructionsMinusIrqs(_) => { 
        
               (InstructionsMinusIrqs::NAME, r#"[["instructions", 1]]"#) 
        
           } 
        
           Counter::InstructionsMinusRaw0420(_) => { 
        
               (InstructionsMinusRaw0420::NAME, r#"[["instructions", 1]]"#) 
        
           }

So we should be able to pretty-print an u64 that measures nanoseconds, as the appropriate unit for a maximum number of "significant digits". It's just going to be annoying to thread that state through.

	Counter::WallTime(_) => (
	WallTime::NAME,
	r#"[["ns", 1], ["μs", 1000], ["ms", 1000000], ["s", 1000000000]]"#,
	),
	Counter::Instructions(_) => (Instructions::NAME, r#"[["instructions", 1]]"#),
	Counter::InstructionsMinusIrqs(_) => {
	(InstructionsMinusIrqs::NAME, r#"[["instructions", 1]]"#)
	}
	Counter::InstructionsMinusRaw0420(_) => {
	(InstructionsMinusRaw0420::NAME, r#"[["instructions", 1]]"#)
	}

stack_collapse unit tests fail on Windows #173

Description

michaelwoeristeropenedon Aug 26, 2021

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

michaelwoerister
openedon Aug 26, 2021