Skip to content

Fix websocket port option for serve #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2017
Merged

Conversation

marvinvi
Copy link

Websocket port option does not work since mdbook.rs use --websocket-port in arguments and use ws-port in implementation.

@azerupi azerupi added this to the 0.1.0 milestone May 26, 2017
@azerupi
Copy link
Contributor

azerupi commented May 26, 2017

Thank you for the PR!
So looking at it now, I would actually prefer to keep the more verbose name --websocket-port.
If you change that I can merge the PR :)

@marvinvi
Copy link
Author

Done. :)

@azerupi azerupi merged commit 4364ec3 into rust-lang:master May 26, 2017
@azerupi
Copy link
Contributor

azerupi commented May 26, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants