Fix print page links for internal links to non-chapters #2914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An example where this can happen is a link to a page that was renamed and redirected, or just a normal HTML file.
This fixes links on the print page that go to an internal destination that is not a chapter. The path would have the wrong relative destination, and would be broken. The logic for detecting this was incorrectly only checking if a link went outside the book, or didn't have an html extension. This doesn't work for links to HTML files that are inside the book, but not one of the chapters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes links on the print page that go to an internal destination that is not a chapter. The path would have the wrong relative destination, and would be broken. The logic for detecting this was incorrectly only checking if a link went outside the book, or didn't have an html extension. This doesn't work for links to HTML files that are inside the book, but not one of the chapters.