Adding Frontmatter Reader: Support summary card (OG. Twitter) #2321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, would you have time to rebase this to make it easier to review it, please? |
szabgab
reviewed
Apr 3, 2025
| @@ -35,6 +35,9 @@ shlex = "1.3.0" | |||
| tempfile = "3.4.0" | |||
| toml = "0.5.11" # Do not update, see https://github.com/rust-lang/mdBook/issues/2037 | |||
| topological-sort = "0.2.2" | |||
| gray_matter = "0.2" #Fronmatter | |||
| serde_yaml = "0.9" | |||
There was a problem hiding this comment.
serde_yaml was deprecated recently, please use serde_yml
szabgab
reviewed
Apr 3, 2025
| use serde::Deserialize; | ||
|
|
||
| fn extract_frontmatter(content: &str) -> Option<&str> { | ||
| let start = content.find("---")? + 3; // Find the end of the first `---` + 3 to move past it |
There was a problem hiding this comment.
Given that --- can appear anywhere in a regular markdown content, I'd restrict this to the case when the file starts with ---.
|
☔ The latest upstream changes (possibly #2681) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issues #1416 and specific description in my comment: #1416 (comment).
This works for my site dedp.online, but I'd appreciate some help to integrate it nicely. It's more hackable and hard-coded to these frontmatter I used:
Would be nice to read them dynamically. Also, I'm not sure if I added it at the right points.
PS: I also tried to implement a preprocessor (see #1416 (comment)), but with this PR that one is not needed anymore. Also, I guess this should be integrated into mdBook, and can't be as Preprocessor only?