Skip to content

Use fixed positioning and remove overflow-x's for smoother scrolling … #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2016

Conversation

thomastanck
Copy link
Contributor

…experience in iOS

Fixes #180 \o/

I've only tested this on Firefox 49.0.2 and iOS 10.0.2 Safari (iPhone 5). Please check that the intended behaviour is preserved on all supported platforms! At least for me, it seems to work perfectly (scrolling behaviour and element positioning) on both Firefox and iOS Safari on many different screen sizes.

@azerupi
Copy link
Contributor

azerupi commented Nov 9, 2016

Thanks!
I will test this in the coming days. :)

@thomastanck
Copy link
Contributor Author

How are the tests going?

@azerupi azerupi merged commit cf35e08 into rust-lang:master Nov 22, 2016
@azerupi
Copy link
Contributor

azerupi commented Nov 22, 2016

Sorry for the delay..
I have not seen any regressions, on the contrary, it solves a scrolling bug with the arrow keys on desktop too! 👍

Thanks a lot! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants