Define XATTR flags, and add XATTR functions for OSX #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, it looks like we don't have xattr functions for OSX yet. Adding those now. |
|
Done. It should be noted that OSX doesn't have lgetxattr, lsetxattr, etc. but rather uses a flag passed to the base versions of those functions. |
|
It should also be noted that in regards to OSX I'm relying on Travis to test my changes as I don't have an OSX machine. I was hoping this would be a constant only change. |
PlasmaPower
force-pushed
the
xattr-flags
branch
2 times, most recently
from
091f0c1 to
a3b5ee1
Compare
PlasmaPower
changed the title
|
Ok, Travis is passing so it looks like my function signatures are finally correct. |
|
Looks great to me, thanks! @bors: r+ |
|
📌 Commit 1a06678 has been approved by |
bors
added a commit
that referenced
this pull request
May 8, 2017
Define XATTR flags, and add XATTR functions for OSX As found in: http://elixir.free-electrons.com/linux/latest/source/include/uapi/linux/xattr.h https://opensource.apple.com/source/xnu/xnu-2050.7.9/bsd/sys/xattr.h
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found in:
http://elixir.free-electrons.com/linux/latest/source/include/uapi/linux/xattr.h
https://opensource.apple.com/source/xnu/xnu-2050.7.9/bsd/sys/xattr.h