Add missing constants from unistd.h for newlib targets
#4811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-newlib
O-unix
S-waiting-on-review
stable-nominated
tgross35
requested changes
Nov 4, 2025
Contributor
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
Thanks for the fix, I have a few small nits here.
Could you also move these constants to src/new/newlib/unistd.rs? We're slowly migrating to a structure that follows the source closer.
FenrirWolf
force-pushed
the
newlib_constants
branch
from
0057679 to
8a4b635
Compare
Contributor
Author
|
Sure, I moved the definitions and changed them to match the source too. |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
(backport <rust-lang#4811>) (cherry picked from commit e654f3a)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 4, 2025
(backport <rust-lang#4811>) (cherry picked from commit e654f3a)
pheki
pushed a commit
to vita-rust/libc
that referenced
this pull request
Nov 21, 2025
(backport <rust-lang#4811>) (cherry picked from commit e654f3a)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Dec 2, 2025
(backport <rust-lang#4811>) (cherry picked from commit e654f3a)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Dec 2, 2025
(backport <rust-lang#4811>) (cherry picked from commit e654f3a)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Dec 2, 2025
(backport <rust-lang#4811>) (cherry picked from commit e654f3a)
Contributor
|
I'm going through the backports and just FYI, this commit didn't get attributed to you for some reason. Per https://github.com/rust-lang/libc/commit/8a4b635aeae3b68da7ef8c40d190c10a73e30526.patch this was authored by Perhaps that is intentional, but figured it's worth letting you know in case it comes from a bad bash env or something :) |
Merged
tgross35
removed
the
stable-nominated
tgross35
added
the
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new API was recently added to
std, and as a result a number of newlib-based targets are failing to build due to a missing definition for_SC_HOST_NAME_MAXfrom theunistd.hheader. This PR adds that missing constant along with a number of othersysconfsymbols that never made it into the crate for these targets.Sources
https://github.com/bminor/newlib/blob/master/newlib/libc/include/sys/unistd.h#L354-L512
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated