cleanup: Simplify the syntax of f! and similar macros
#4714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-android
O-bsd
O-dragonfly
O-linux
O-linux-like
O-macos
O-newlib
O-redox
O-solarish
O-unix
S-waiting-on-review
stable-nominated
We no longer need to support gating `const` behind
`libc_const_extern_fn`, so remove the awkward `{const}` syntax.
tgross35
force-pushed
the
simplify-function-macros
branch
from
e2e2a8b to
1483c7c
Compare
Now that is okay for functions to be always `const`, this macro doesn't add anything other than the `#[inline]` attribute, which isn't useful for private functions anyway. Thus, remove the macro and leave its contents wherever it is used.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 23, 2025
We no longer need to support gating `const` behind
`libc_const_extern_fn`, so remove the awkward `{const}` syntax.
(backport <rust-lang#4714>)
(cherry picked from commit e860257)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 23, 2025
Now that is okay for functions to be always `const`, this macro doesn't add anything other than the `#[inline]` attribute, which isn't useful for private functions anyway. Thus, remove the macro and leave its contents wherever it is used. (backport <rust-lang#4714>) (cherry picked from commit dcde5cd)
Merged
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 23, 2025
We no longer need to support gating `const` behind
`libc_const_extern_fn`, so remove the awkward `{const}` syntax.
(backport <rust-lang#4714>)
(cherry picked from commit e860257)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 23, 2025
Now that is okay for functions to be always `const`, this macro doesn't add anything other than the `#[inline]` attribute, which isn't useful for private functions anyway. Thus, remove the macro and leave its contents wherever it is used. (backport <rust-lang#4714>) (cherry picked from commit dcde5cd)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 23, 2025
We no longer need to support gating `const` behind
`libc_const_extern_fn`, so remove the awkward `{const}` syntax.
(backport <rust-lang#4714>)
(cherry picked from commit e860257)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 23, 2025
Now that is okay for functions to be always `const`, this macro doesn't add anything other than the `#[inline]` attribute, which isn't useful for private functions anyway. Thus, remove the macro and leave its contents wherever it is used. (backport <rust-lang#4714>) (cherry picked from commit dcde5cd)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 23, 2025
We no longer need to support gating `const` behind
`libc_const_extern_fn`, so remove the awkward `{const}` syntax.
(backport <rust-lang#4714>)
(cherry picked from commit e860257)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 23, 2025
Now that is okay for functions to be always `const`, this macro doesn't add anything other than the `#[inline]` attribute, which isn't useful for private functions anyway. Thus, remove the macro and leave its contents wherever it is used. (backport <rust-lang#4714>) (cherry picked from commit dcde5cd)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to support gating
constbehindlibc_const_extern_fn, so remove the awkward{const}syntax.@rustbot label +stable-nominated