Skip to content

Remove a number of hacks for the old ctest #4713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 23, 2025
Merged

Remove a number of hacks for the old ctest #4713

merged 5 commits into from
Sep 23, 2025

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Sep 23, 2025 •
edited
Loading

Details are in each commit message.

@rustbot label +stable-nominated

@rustbot rustbot added O-wasi S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Sep 23, 2025
@tgross35 tgross35 enabled auto-merge September 23, 2025 03:42
@tgross35
Remove the libc_ctest feature
9697f27 
This was a workaround for the old ctest not being able to parse
something related to the `addr_of!` macros in statics referencing
statics. This is not needed with the new ctest; thus, remove the config.
@tgross35 tgross35 changed the title Remove the libc_ctest feature Remove a number of hacks for the old ctest Sep 23, 2025
@tgross35 tgross35 force-pushed the no-libc-ctest-cfg branch 2 times, most recently from 8a1e4a4 to 4514c06 Compare September 23, 2025 04:50
@tgross35
doc: Remove an unneeded link to the old ctest repo
86fe6e5
@tgross35
cleanup: Use target_vendor = "apple"
bd291ac 
The old ctest couldn't handle `target_vendor`, but this is no longer an
issue. Simplify the config here.
@tgross35
ci: Update a comment about skipping wasm
b0559ae 
We still need to skip testing ctest on wasm, but no longer because of
ctest itself.
@tgross35 tgross35 added this pull request to the merge queue Sep 23, 2025
auto-merge was automatically disabled September 23, 2025 05:52

Pull Request is not mergeable

Merged via the queue into rust-lang:main with commit e4b64bb Sep 23, 2025
98 of 100 checks passed
@tgross35 tgross35 deleted the no-libc-ctest-cfg branch September 23, 2025 06:02
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
Remove the libc_ctest feature
e40df6d 
This was a workaround for the old ctest not being able to parse
something related to the `addr_of!` macros in statics referencing
statics. This is not needed with the new ctest; thus, remove the config.

(backport <rust-lang#4713>)
(cherry picked from commit 4f2c41a)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
Resolve a ctest FIXME regarding use of size_of in array lengths
c2b0581 
(backport <rust-lang#4713>)
(cherry picked from commit 6f0ebb8)
[ note that there was no FIXME comment on 0.2 - Trevor ]
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
doc: Remove an unneeded link to the old ctest repo
9a5ba87 
(backport <rust-lang#4713>)
(cherry picked from commit 1880ba5)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
cleanup: Use target_vendor = "apple"
337f2a2 
The old ctest couldn't handle `target_vendor`, but this is no longer an
issue. Simplify the config here.

(backport <rust-lang#4713>)
(cherry picked from commit 94e3f98)
@tgross35 tgross35 mentioned this pull request Sep 23, 2025
Merged
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
Remove the libc_ctest feature
aab450b 
This was a workaround for the old ctest not being able to parse
something related to the `addr_of!` macros in statics referencing
statics. This is not needed with the new ctest; thus, remove the config.

(backport <rust-lang#4713>)
(cherry picked from commit 4f2c41a)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
Resolve a ctest FIXME regarding use of size_of in array lengths
6b0790d 
(backport <rust-lang#4713>)
(cherry picked from commit 6f0ebb8)
[ note that there was no FIXME comment on 0.2 - Trevor ]
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
doc: Remove an unneeded link to the old ctest repo
c4462bf 
(backport <rust-lang#4713>)
(cherry picked from commit 1880ba5)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
cleanup: Use target_vendor = "apple"
b0013c5 
The old ctest couldn't handle `target_vendor`, but this is no longer an
issue. Simplify the config here.

(backport <rust-lang#4713>)
(cherry picked from commit 94e3f98)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
Remove the libc_ctest feature
f5b8474 
This was a workaround for the old ctest not being able to parse
something related to the `addr_of!` macros in statics referencing
statics. This is not needed with the new ctest; thus, remove the config.

(backport <rust-lang#4713>)
(cherry picked from commit 4f2c41a)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
Resolve a ctest FIXME regarding use of size_of in array lengths
db812e2 
(backport <rust-lang#4713>)
(cherry picked from commit 6f0ebb8)
[ note that there was no FIXME comment on 0.2 - Trevor ]
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
doc: Remove an unneeded link to the old ctest repo
17af285 
(backport <rust-lang#4713>)
(cherry picked from commit 1880ba5)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
cleanup: Use target_vendor = "apple"
12ff242 
The old ctest couldn't handle `target_vendor`, but this is no longer an
issue. Simplify the config here.

(backport <rust-lang#4713>)
(cherry picked from commit 94e3f98)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
Remove the libc_ctest feature
b5f8675 
This was a workaround for the old ctest not being able to parse
something related to the `addr_of!` macros in statics referencing
statics. This is not needed with the new ctest; thus, remove the config.

(backport <rust-lang#4713>)
(cherry picked from commit 4f2c41a)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
Resolve a ctest FIXME regarding use of size_of in array lengths
be5538b 
(backport <rust-lang#4713>)
(cherry picked from commit 6f0ebb8)
[ note that there was no FIXME comment on 0.2 - Trevor ]
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
doc: Remove an unneeded link to the old ctest repo
341fa37 
(backport <rust-lang#4713>)
(cherry picked from commit 1880ba5)
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Sep 23, 2025
@tgross35
cleanup: Use target_vendor = "apple"
f96995d 
The old ctest couldn't handle `target_vendor`, but this is no longer an
issue. Simplify the config here.

(backport <rust-lang#4713>)
(cherry picked from commit 94e3f98)
github-merge-queue bot pushed a commit that referenced this pull request Sep 23, 2025
@tgross35
Remove the libc_ctest feature
09c8436 
This was a workaround for the old ctest not being able to parse
something related to the `addr_of!` macros in statics referencing
statics. This is not needed with the new ctest; thus, remove the config.

(backport <#4713>)
(cherry picked from commit 4f2c41a)
github-merge-queue bot pushed a commit that referenced this pull request Sep 23, 2025
@tgross35
Resolve a ctest FIXME regarding use of size_of in array lengths
8c8584b 
(backport <#4713>)
(cherry picked from commit 6f0ebb8)
[ note that there was no FIXME comment on 0.2 - Trevor ]
github-merge-queue bot pushed a commit that referenced this pull request Sep 23, 2025
@tgross35
doc: Remove an unneeded link to the old ctest repo
d32f60d 
(backport <#4713>)
(cherry picked from commit 1880ba5)
github-merge-queue bot pushed a commit that referenced this pull request Sep 23, 2025
@tgross35
cleanup: Use target_vendor = "apple"
776a614 
The old ctest couldn't handle `target_vendor`, but this is no longer an
issue. Simplify the config here.

(backport <#4713>)
(cherry picked from commit 94e3f98)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
O-linux O-musl O-unix O-wasi stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgross35 @rustbot