Remove libc_const_extern_fn
#4712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
added
the
stable-nominated
tgross35
force-pushed
the
no-const-extern-fn-feature
branch
from
49b1b89 to
036535f
Compare
This originally existed for MSRV support, then became a necessary hack to support the old ctest's inability to parse `const fn`. The new ctest doesn't have this limitation, so remove the config. Additionally, switch from the `*` kleene to `?` since that is possible now.
tgross35
force-pushed
the
no-const-extern-fn-feature
branch
from
036535f to
b94f6ba
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 23, 2025
This originally existed for MSRV support, then became a necessary hack to support the old ctest's inability to parse `const fn`. The new ctest doesn't have this limitation, so remove the config. Additionally, switch from the `*` kleene to `?` since that is possible now. (backport <rust-lang#4712>) (cherry picked from commit 4894081)
Merged
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 23, 2025
This originally existed for MSRV support, then became a necessary hack to support the old ctest's inability to parse `const fn`. The new ctest doesn't have this limitation, so remove the config. Additionally, switch from the `*` kleene to `?` since that is possible now. (backport <rust-lang#4712>) (cherry picked from commit 4894081)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 23, 2025
This originally existed for MSRV support, then became a necessary hack to support the old ctest's inability to parse `const fn`. The new ctest doesn't have this limitation, so remove the config. Additionally, switch from the `*` kleene to `?` since that is possible now. (backport <rust-lang#4712>) (cherry picked from commit 4894081)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 23, 2025
This originally existed for MSRV support, then became a necessary hack to support the old ctest's inability to parse `const fn`. The new ctest doesn't have this limitation, so remove the config. Additionally, switch from the `*` kleene to `?` since that is possible now. (backport <rust-lang#4712>) (cherry picked from commit 4894081)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 23, 2025
This originally existed for MSRV support, then became a necessary hack to support the old ctest's inability to parse `const fn`. The new ctest doesn't have this limitation, so remove the config. Additionally, switch from the `*` kleene to `?` since that is possible now. (backport <#4712>) (cherry picked from commit 4894081)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This originally existed for MSRV support, then became a necessary hack to support the old ctest's inability to parse
const fn. The new ctest doesn't have this limitation, so remove the config.