-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ci: Upgrade to the windows-2025 runner #4566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
df63386 to
12a4d97
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
With the update to Windows-2025, MinGW is now using the UCRT values for `L_tmpnam` and `TMP_MAX`, which match the MSVC values. Since the values are now identical, consolidate the constants. Link: mingw-w64/mingw-w64@c7c93e3 Link: mingw-w64/mingw-w64@124ee27
12a4d97 to
ce82b71
Compare
|
@JohnTitor just want to make sure the second commit here seems reasonable since it undoes 9d338ff :) |
JohnTitor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I believe yours is a better fix, thank you!
(backport <rust-lang#4566>) (cherry picked from commit 22cef5b)
With the update to Windows-2025, MinGW is now using the UCRT values for `L_tmpnam` and `TMP_MAX`, which match the MSVC values. Since the values are now identical, consolidate the constants. Link: mingw-w64/mingw-w64@c7c93e3 Link: mingw-w64/mingw-w64@124ee27 (backport <rust-lang#4566>) (cherry picked from commit b54769a)
With the update to Windows-2025, MinGW is now using the UCRT values for `L_tmpnam` and `TMP_MAX`, which match the MSVC values. Since the values are now identical, consolidate the constants. Link: mingw-w64/mingw-w64@c7c93e3 Link: mingw-w64/mingw-w64@124ee27 (backport <rust-lang#4566>) (cherry picked from commit b54769a)
(backport <rust-lang#4566>) (cherry picked from commit 22cef5b)
With the update to Windows-2025, MinGW is now using the UCRT values for `L_tmpnam` and `TMP_MAX`, which match the MSVC values. Since the values are now identical, consolidate the constants. Link: mingw-w64/mingw-w64@c7c93e3 Link: mingw-w64/mingw-w64@124ee27 (backport <rust-lang#4566>) (cherry picked from commit b54769a)
With the update to Windows-2025, MinGW is now using the UCRT values for `L_tmpnam` and `TMP_MAX`, which match the MSVC values. Since the values are now identical, consolidate the constants. Link: mingw-w64/mingw-w64@c7c93e3 Link: mingw-w64/mingw-w64@124ee27 (backport <#4566>) (cherry picked from commit b54769a)
No description provided.