Skip to content

Add AT_MINSIGSTKSZ for android #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Add AT_MINSIGSTKSZ for android #3732

merged 1 commit into from
Jun 18, 2024

Conversation

ur4t
Copy link
Contributor

@ur4t ur4t commented Jun 4, 2024

Add AT_MINSIGSTKSZ for android, which was not performed by #3637 .

@rustbot
Copy link
Collaborator

rustbot commented Jun 4, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@JohnTitor JohnTitor added this pull request to the merge queue Jun 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 17, 2024
@JohnTitor JohnTitor added this pull request to the merge queue Jun 18, 2024
Merged via the queue into rust-lang:libc-0.2 with commit a1b296a Jun 18, 2024
57 checks passed
@tgross35 tgross35 added the main-needs-cherry-pick This PR was merged against libc-0.2 but does not yet exist in main. label Aug 13, 2024
@ur4t
Copy link
Contributor Author

ur4t commented Aug 17, 2024

@tgross35 This PR (#3732) has been cherry-picked to main as part of #3699 with commit hash 5b9628e.

@tgross35
Copy link
Contributor

Ah thanks! Try to cherry pick with -xe if you do others in the future, it's tough to figure out how things crosslink otherwise (some more here https://github.com/rust-lang/libc/blob/main/CONTRIBUTING.md#v10-roadmap).

@tgross35 tgross35 removed the main-needs-cherry-pick This PR was merged against libc-0.2 but does not yet exist in main. label Aug 17, 2024
@ur4t
Copy link
Contributor Author

ur4t commented Aug 17, 2024

@tgross35 Thanks for the guidance, and praise the refined workflow! It is indeed much cleaner for both maintainers and contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants