Migrate libc-test to edition 2018 #3718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
edition: cannot update to 2021 edition because of libc msrv. cargo of rust 1.19 cannot understand edition key in cargo.toml.
no semver vendor = 'unknown'
tesuji
changed the title
JohnTitor
approved these changes
May 23, 2024
tgross35
added
the
main-needs-cherry-pick
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Aug 29, 2024
edition: cannot update to 2021 edition because of libc msrv. cargo of rust 1.19 cannot understand edition key in cargo.toml. (cherry picked from commit 4057a9a) avoid rebuilding libc-test no semver vendor = 'unknown' (cherry picked from commit de2c8a7) use rel path for semver (cherry picked from commit d6d56f1) (apply <rust-lang#3718> to `main`) [ resolve conflicts, squash for easier cherry-picks - Trevor ]
tgross35
added
main-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libc-test depens on ctest2 which has MSRV as 1.56, which already support 2018 edition.
Also remove
unkown.txtfromcargo:run_if. That made build script keeps running again compiled.