-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Avoid usage of thread_local on DragonFlyBSD #3653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
64bd72c to
1ab93fb
Compare
__error() has been deprecated and return the same value as __errno_location(). Removing the __error() function eliminates the sole use of thread_local in this crate.
1ab93fb to
de76fee
Compare
JohnTitor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Looks like this never made it to the 0.2 branch. Picking it up now since this helps us avoid some conflicts (unstable feature on a T3 target) @rustbot label +stable-nominated |
__error() has been deprecated and return the same value as __errno_location(). Removing the __error() function eliminates the sole use of thread_local in this crate. (backport <rust-lang#3653>) (cherry picked from commit de76fee) [ resolved conflicts in all files and removed the now-unused `rustc_dep_of_std` - Trevor ]
__error() has been deprecated and return the same value as __errno_location(). Removing the __error() function eliminates the sole use of thread_local in this crate. (backport <#3653>) (cherry picked from commit de76fee) [ resolved conflicts in all files and removed the now-unused `rustc_dep_of_std` - Trevor ]
Both __errno_location() and __error() return the same value, so the __error() function can be implemented on the Rust side as __errno_location(). This eliminates the sole use of thread_local in this crate.