Skip to content

update android sdk version #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Takashiidobe
Copy link
Contributor

@Takashiidobe Takashiidobe commented Dec 25, 2023

CI is passing, but I don't know how to verify if this change is actually working.

@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@Takashiidobe Takashiidobe marked this pull request as draft December 25, 2023 16:47
@JohnTitor
Copy link
Member

Note that CI on PRs doesn't trigger all the jobs, you could verify if it works by running run-docker.sh like CI.
You also have to add more tweaks, see #3439 (N.B. it's incomplete!).

@Takashiidobe
Copy link
Contributor Author

Will reopen when the android CI is fixed, I couldn't figure out how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants