Skip to content

Add SIGCHLD and other signals #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2016

Conversation

dlrobertson
Copy link
Contributor

@dlrobertson dlrobertson commented Jul 10, 2016

Add SIGCHLD, SIGSTOP, SIGTSTP, SIGCONT, SIGTTIN, SIGTTOU. Improve
consistency across oses, by adding SIGEMT to relevant oses.

Note: there are still many lesser known signals missing (SIGXCPU, SIGPROF, etc)


This change is Reviewable

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Looks like there may be some duplicate definitions that CI doesn't like?

Add SIGCHLD, SIGSTOP, SIGTSTP, SIGCONT, SIGTTIN, SIGTTOU. Improve
consistency across oses, by adding SIGEMT to relevant oses.
@alexcrichton
Copy link
Member

Thanks!

@alexcrichton alexcrichton merged commit 08a2abb into rust-lang:master Jul 11, 2016
@dlrobertson
Copy link
Contributor Author

np! sorry for 1) missing the fact that SIGCHILD etc had already been added, and 2) forgetting to comment when I updated the PR

@dlrobertson dlrobertson deleted the more_signals branch November 11, 2016 01:23
Susurrus pushed a commit to Susurrus/libc that referenced this pull request Mar 26, 2017
epoll: Add EPOLLEXCLUSIVE flag.

EPOLLEXCLUSIVE flag is available in Linux4.5.
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
This seems likely to have mostly just been a copy/paste error, so this
re-reviews the intrinsics and aligns it with the implementation in
clang.

Closes rust-lang#328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants