Fix FreeBSD CPU_ macros #2842
Merged
Fix FreeBSD CPU_ macros #2842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current definitions conflate bits and bytes, leading to panics.
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
|
FYI @asomers, not sure if there's any other broken stuff added for FreeBSD recently. |
|
Good catch. Maybe there should be unit tests for those functions? |
|
@asomers I'll improve the test coverage in |
|
@bors r+ |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current definitions conflate bits and bytes, leading to panics.
Found while trying to add support for
nix::sched::sched_setaffinityto FreeBSD.