Skip to content

linux/glibc tagged ptr supports for arm64 control addition. #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2022
Merged

linux/glibc tagged ptr supports for arm64 control addition. #2833

merged 1 commit into from
Jun 26, 2022

Conversation

devnexen
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

JohnTitor
JohnTitor reviewed Jun 24, 2022
View reviewed changes
src/unix/linux_like/linux/gnu/b64/aarch64/mod.rs Outdated
Comment on lines 579 to 580
pub const PR_GET_TAGGED_ADDR_CTRL: ::c_int = 56;
pub const PR_GET_TAGGED_ADDR_CTRL: ::c_int = 55;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub const PR_GET_TAGGED_ADDR_CTRL: ::c_int = 56;
pub const PR_GET_TAGGED_ADDR_CTRL: ::c_int = 55;
pub const PR_SET_TAGGED_ADDR_CTRL: ::c_int = 55;
pub const PR_GET_TAGGED_ADDR_CTRL: ::c_int = 56;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes too quick copy paste :-)

@devnexen
Copy link
Contributor Author

Above all waiting if the aux vec flag will pass during CI then would make sense to uncomment the rest.

@devnexen devnexen force-pushed the linux_prctl_update branch from 3e22a30 to 10ba417 Compare June 24, 2022 05:38
@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 24, 2022

📌 Commit 10ba417 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Jun 24, 2022

⌛ Testing commit 10ba417 with merge cd55991...

bors added a commit that referenced this pull request Jun 24, 2022
@bors
Auto merge of #2833 - devnexen:linux_prctl_update, r=JohnTitor
cd55991 
linux/glibc tagged ptr supports for arm64 control addition.
@bors
Copy link
Contributor

bors commented Jun 24, 2022

💔 Test failed - checks-actions

@devnexen devnexen force-pushed the linux_prctl_update branch from 10ba417 to 76ce631 Compare June 25, 2022 04:12
@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 25, 2022

📌 Commit 76ce631 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Jun 25, 2022

⌛ Testing commit 76ce631 with merge f1d3afa...

bors added a commit that referenced this pull request Jun 25, 2022
@bors
Auto merge of #2833 - devnexen:linux_prctl_update, r=JohnTitor
f1d3afa 
linux/glibc tagged ptr supports for arm64 control addition.
@bors
Copy link
Contributor

bors commented Jun 25, 2022

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member 

 error[E0432]: unresolved imports `libc::PR_GET_TAGGED_ADDR_CTRL`, `libc::PR_SET_TAGGED_ADDR_CTRL`, `libc::PR_TAGGED_ADDR_ENABLE`
    --> /checkout/target/aarch64-unknown-linux-musl/debug/build/libc-test-d622df2af2fc66ce/out/semver.rs:4059:5
     |
4059 |     PR_GET_TAGGED_ADDR_CTRL,
     |     ^^^^^^^^^^^^^^^^^^^^^^^ no `PR_GET_TAGGED_ADDR_CTRL` in the root
4060 |     PR_SET_TAGGED_ADDR_CTRL,
     |     ^^^^^^^^^^^^^^^^^^^^^^^ no `PR_SET_TAGGED_ADDR_CTRL` in the root
4061 |     PR_TAGGED_ADDR_ENABLE,
     |     ^^^^^^^^^^^^^^^^^^^^^ no `PR_TAGGED_ADDR_ENABLE` in the root

The semver check fails on aarch64-unknown-linux-musl.

@devnexen devnexen force-pushed the linux_prctl_update branch from 76ce631 to a7df4de Compare June 26, 2022 09:08
@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 26, 2022

📌 Commit a7df4de has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Jun 26, 2022

⌛ Testing commit a7df4de with merge ce3d1a2...

@bors
Copy link
Contributor

bors commented Jun 26, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing ce3d1a2 to master...

@bors bors merged commit ce3d1a2 into rust-lang:master Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devnexen @rust-highfive @JohnTitor @bors @Amanieu