-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add rtnetlink.h, if_link.h, if_addr.h to Android #2830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
Could you squash commits into one? |
c5b5290
to
96c5d31
Compare
I have updated the commit and force pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@bors r+ |
📌 Commit 96c5d31 has been approved by |
Add rtnetlink.h, if_link.h, if_addr.h to Android Here is the NDK header: [rtnetlink.h](https://android.googlesource.com/platform/prebuilts/ndk/+/dev/platform/sysroot/usr/include/linux/rtnetlink.h) [if_link.h](https://android.googlesource.com/platform/prebuilts/ndk/+/dev/platform/sysroot/usr/include/linux/if_link.h) [if_addr.h](https://android.googlesource.com/platform/prebuilts/ndk/+/dev/platform/sysroot/usr/include/linux/if_addr.h) It is the same with Linux header, so i copied it from:https://github.com/rust-lang/libc/blob/master/src/unix/linux_like/linux/mod.rs
💔 Test failed - checks-actions |
It seems that x86_64 header of NDK is different with aarch64, i will figure it out |
There are two problems:
So i remove the if_addr.h temporarily, and i remove the four IFLA_* variable. There are two things to do:
But i think the upgrade may occur other issues, after i fixed it, i will make another PRs |
You could tweak the test here to include additional headers: Line 1472 in f292633
|
Thank you, i have updated the header |
@bors r+ |
📌 Commit 15e132b has been approved by |
Add rtnetlink.h, if_link.h, if_addr.h to Android Here is the NDK header: [rtnetlink.h](https://android.googlesource.com/platform/prebuilts/ndk/+/dev/platform/sysroot/usr/include/linux/rtnetlink.h) [if_link.h](https://android.googlesource.com/platform/prebuilts/ndk/+/dev/platform/sysroot/usr/include/linux/if_link.h) [if_addr.h](https://android.googlesource.com/platform/prebuilts/ndk/+/dev/platform/sysroot/usr/include/linux/if_addr.h) It is the same with Linux header, so i copied it from:https://github.com/rust-lang/libc/blob/master/src/unix/linux_like/linux/mod.rs
💔 Test failed - checks-actions |
I checked the header, these fields are not exist : RTMSG_NEWRULE
RTMSG_DELRULE
RTMSG_CONTROL
RTMSG_AR_FAILED
MAX_ADDR_LEN
ARPD_UPDATE
ARPD_LOOKUP
ARPD_FLUSH
ATF_MAGIC |
@bors r+ |
📌 Commit f5b4740 has been approved by |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Here is the NDK header:
rtnetlink.h
if_link.h
if_addr.h
It is the same with Linux header, so i copied it from:https://github.com/rust-lang/libc/blob/master/src/unix/linux_like/linux/mod.rs