notbsd: Deduplicate definitions #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of definitions were duplicated across, eg, android and linux. This commit pulls these up to higher levels where they can be shared.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I think this is right. Don't merge until the build is done so we can check the number of tests are the same. I definitely lost some while doing this!
|
|
(That function was found, as were 8 I lost on mips.) |
|
I think there's something wrong with the current OS X nightly
|
|
Checked the numbers of tests on all architectures, and they match the most recent passing master build. |
|
Yeah, I think that could be good but less important than #270. |
bors
added a commit
that referenced
this pull request
Apr 28, 2016
notbsd: Deduplicate definitions A bunch of definitions were duplicated across, eg, android and linux. This commit pulls these up to higher levels where they can be shared.
|
☀️ Test successful - status-appveyor, travis |
danielverkamp
pushed a commit
to danielverkamp/libc
that referenced
this pull request
Apr 28, 2020
This migrates the entire `i686::sse` module (and touches a few others) to the vendor types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of definitions were duplicated across, eg, android and linux.
This commit pulls these up to higher levels where they can be shared.