Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore the type of the parameter flags of getnameinfo to c_int #1993

Merged
merged 1 commit into from
Dec 10, 2020
Merged

restore the type of the parameter flags of getnameinfo to c_int #1993

merged 1 commit into from
Dec 10, 2020

Conversation

kolapapa
Copy link
Contributor

@kolapapa kolapapa commented Dec 9, 2020

Restore the type of the parameter flags of getnameinfo to c_int

At present, all the implementation parameters of getnameinfo flags are of type int, and some constants defined are also of type int. I have seen the implementation of uclibc. The flags values are basically macro definitions, so should we not do this by uclibc alone kind of special treatment.

These several places also define the int type.
https://github.com/rust-lang/libc/blob/master/src/unix/uclibc/mod.rs#L1375

@rust-highfive
Copy link

r? @JohnTitor

(rust-highfive has picked a reviewer for you, use r? to override)

@kolapapa
Copy link
Contributor Author

kolapapa commented Dec 9, 2020

other question ... how to merge the newest tag to fork version?

@JohnTitor
Copy link
Member

This would be a breaking change but given you introduced it recently and it should be reasonable, I'm fine to accept it.
Could you use rebase instead of merge here?

how to merge the newest tag to fork version?

I usually do git pull upstream master (assuming you have upstream).

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 10, 2020

📌 Commit 1f5debf has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Dec 10, 2020

⌛ Testing commit 1f5debf with merge 3f9b323...

@bors
Copy link
Contributor

bors commented Dec 10, 2020

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 3f9b323 to master...

@bors bors merged commit 3f9b323 into rust-lang:master Dec 10, 2020
@bors bors mentioned this pull request Dec 10, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants