Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getnameinfo && EAI_NODATA in uclibc #1979

Merged
merged 2 commits into from
Nov 25, 2020
Merged

add getnameinfo && EAI_NODATA in uclibc #1979

merged 2 commits into from
Nov 25, 2020

Conversation

kolapapa
Copy link
Contributor

when compiling dns-lookup v1.0.5 in target mipsel-unknown-linux-uclibc

error[E0432]: unresolved import `libc::getnameinfo`
error[E0531]: cannot find unit struct, unit variant or constant `EAI_NODATA` in crate `c`

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

src/unix/uclibc/mod.rs Outdated Show resolved Hide resolved
change `getnameinfo` flags type to `c_uint`

Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
@JohnTitor
Copy link
Member

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Nov 25, 2020

📌 Commit 2e14399 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Nov 25, 2020

⌛ Testing commit 2e14399 with merge 84c12a4...

@bors
Copy link
Contributor

bors commented Nov 25, 2020

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 84c12a4 to master...

@bors bors merged commit 84c12a4 into rust-lang:master Nov 25, 2020
@bors bors mentioned this pull request Nov 25, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants