PSP: A few corrections to types and function signatures #1864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor (rust_highfive has picked a reviewer for you, use r? to override) |
sajattack
force-pushed
the
psp-corrections
branch
from
e00f383 to
b1b003e
Compare
|
Hm, CI failed to generate docs, could you take a look? |
|
I saw that but couldn't make sense of it. Maybe a problem with the enum macro? @MrAwesome |
JohnTitor
reviewed
Aug 18, 2020
sajattack
force-pushed
the
psp-corrections
branch
2 times, most recently
from
0f73eb7 to
c459593
Compare
|
cloudabi target not installed? |
|
It'll be resolved by #1865. Once I merge it then you rebase, CI should work fine. |
|
It's merged, could you rebase? |
sajattack
force-pushed
the
psp-corrections
branch
from
c459593 to
bf8327b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to bother you again, while implementing std we found some mistakes in our libc-facing structs and function signatures.
Changes:
sceRtc{Set,Get}Time_tincorrectly defined the types asi64when they should have beenu32sceRtc{Set,Get}Time64_tvariants addedsockaddrdefinition was completely wrong, correctedin_addrchanged frompub struct in_addr(u32)topub struct in_addr { s_addr: u32 }for better compatibility with std/netc.