Skip to content

Add lockf #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add lockf #1707

wants to merge 1 commit into from

Conversation

pickfire
Copy link
Contributor

Fix #1631

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@semarie
Copy link
Contributor

semarie commented Mar 25, 2020

as lockf() is POSIX function, I am suspecting that it is existing on several unix too (if not all). could you try to move your definition from linux_like to unix directory in order to see what CI will do ? (it should cover most of the supported platform)

Note I have checked that OpenBSD has it, and have same constants too.

@pickfire
Copy link
Contributor Author

@semarie Isn't lockf not a POSIX function? The man page I found is 3 not 2p.

Still I will send another patch.

@semarie
Copy link
Contributor

semarie commented Mar 25, 2020

the POSIX definition is here.

regarding man page section, it is really distribution specific, so I can't really comment :-)

@pickfire
Copy link
Contributor Author

Superseded by #1708

@pickfire pickfire closed this Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing POSIX lockf
4 participants