Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test FreeBSD 12 on latest nightly #1507

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Test FreeBSD 12 on latest nightly #1507

merged 1 commit into from
Sep 13, 2019

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Sep 11, 2019

Let's see if libc update for Rust fixed it.

Fixes #1489

@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@gnzlbg
Copy link
Contributor

gnzlbg commented Sep 11, 2019

@bors: r+

Looking good! cc @asomers

@bors
Copy link
Contributor

bors commented Sep 11, 2019

📌 Commit 6255a45 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Sep 11, 2019

⌛ Testing commit 6255a45 with merge 8f72a8d...

bors added a commit that referenced this pull request Sep 11, 2019
Test FreeBSD 12 on latest nightly

~~Let's see if [libc update](rust-lang/rust#63806) for Rust fixed it.~~

Fixes #1489
@mati865
Copy link
Contributor Author

mati865 commented Sep 11, 2019

Windows is borked.
There was new rustup release recently, could be the reason:

D:\a\1\s>rustup default nightly-x86_64-pc-windows-gnu 
error: could not remove 'setup' file: 'C:\Users\VssAdministrator\.cargo\bin/rustup-init.exe'
info: caused by: Access is denied. (os error 5)

@gnzlbg
Copy link
Contributor

gnzlbg commented Sep 11, 2019

cc @kinnison does this look familiar ?

@kinnison
Copy link

@gnzlbg

If this is a github actions related problem then yes, @alexcrichton and @pietroalbini are both aware of it too and have filed a report with github.

@mati865
Copy link
Contributor Author

mati865 commented Sep 11, 2019

@kinnison it's Azure Pipelines error.

@pietroalbini
Copy link
Member

Let me report this to them.

@kinnison
Copy link

it's Azure Pipelines error.

Most likely the same sort of thing -- i.e. that their baseline image doesn't allow rustup to self-update. They either need to pass --no-self-update to the toolchain installation step, or else make it permitted to self-update.

@gnzlbg
Copy link
Contributor

gnzlbg commented Sep 11, 2019

Is it possible to workaround this here in the meantime ?

@ethomson
Copy link

This issue is being tracked at https://github.com/microsoft/azure-pipelines-image-generation/issues/1224 - in the meantime, using the no-self-update option is recommended.

@bors
Copy link
Contributor

bors commented Sep 11, 2019

💔 Test failed - status-azure

@gnzlbg
Copy link
Contributor

gnzlbg commented Sep 13, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 13, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: freebsdlike: add several utmpx constants #1493

@bors
Copy link
Contributor

bors commented Sep 13, 2019

📌 Commit 6255a45 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Sep 13, 2019

⌛ Testing commit 6255a45 with merge b156fb3...

bors added a commit that referenced this pull request Sep 13, 2019
Test FreeBSD 12 on latest nightly

~~Let's see if [libc update](rust-lang/rust#63806) for Rust fixed it.~~

Fixes #1489
@bors
Copy link
Contributor

bors commented Sep 13, 2019

☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing b156fb3 to master...

@bors bors merged commit 6255a45 into rust-lang:master Sep 13, 2019
@mati865 mati865 deleted the patch-2 branch September 13, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI segfaults on FreeBSD
7 participants