Update newlib socket types to FreeBSD #1477
Conversation
|
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
|
These are breaking changes to all newlib targets, not just FreeBSD right ? |
|
@gnzlbg As far as I'm aware, only me and @FenrirWolf are actually libc newlib. |
|
ok, @bors: r+ |
|
📌 Commit eb287a1 has been approved by |
|
@gnzlbg yeah, these newlib bindings were originally added to support a custom nintendo 3ds homebrew target, and now @leo60228 is using them for a similar toolchain for the nintendo switch. No idea if anyone else has ever tried using them. Technically these changes will break networking for my target, but one way around that would be to put the old definitions in the |
Update newlib socket types to FreeBSD None
|
How are you compiling with these? Do you think it would be possible for you to try to set up some docker containers so that we can run run-time tests for these? |
|
☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
|
@gnzlbg I have a Docker image at |
Define newlib socket types by target arch This is a follow-up to #1477. As mentioned in that PR, the primary (only?) users of these newlib definitions are myself and @leo60228. This PR makes it so that my arm-based 3DS target keeps using the old socket definitions while leo's aarch64-based Switch target uses the BSD versions. The 3DS also has inverted definitions for `POLLHUP` and `POLLOUT` for whatever reason, so I figured I'd take care of that here too.
Define newlib socket types by target arch This is a follow-up to #1477. As mentioned in that PR, the primary (only?) users of these newlib definitions are myself and @leo60228. This PR makes it so that my arm-based 3DS target keeps using the old socket definitions while leo's aarch64-based Switch target uses the BSD versions. The 3DS also has inverted definitions for `POLLHUP` and `POLLOUT` for whatever reason, so I figured I'd take care of that here too.
No description provided.