Skip to content

Offer a c_bool #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

solidsnack
Copy link

No description provided.

@jimblandy
Copy link
Contributor

Pull request #128 is similar to this.

@brson
Copy link
Contributor

brson commented Jan 5, 2016

Thanks! Since #128 comes with tests, and the typedef definition that I think we'll prefer, I'm going to close this in favor of that.

@brson brson closed this Jan 5, 2016
@solidsnack
Copy link
Author

It seems like #128 is a way's away from doing the right thing semantically, with respect to allowed values of bool.

@jimblandy
Copy link
Contributor

It seems like #128 is a way's away from doing the right thing semantically, with respect to allowed values of bool.

@solidsnack: How so? Both C and Rust constrain bool values to be either zero or one.

@solidsnack
Copy link
Author

@jimblandy Maybe I'm missing something but the definition of c_bool in #128 is pub type c_bool = u8;. Is there supposed to be a conversion somewhere?

@jimblandy
Copy link
Contributor

@solidsnack You are not missing something, I screwed up! Man... [re-pushes]

danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants