Add ioctl constants #123
Merged
Add ioctl constants #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the constants are the same for all unix. |
|
Will the ci pick that up? |
|
The CI has picked it up :) |
richard-uk1
force-pushed
the
add_ioctl_constants
branch
2 times, most recently
from
4fc952b to
7527f4b
Compare
|
It seems that android uses int, whereas linux uses unsigned long for the __request in ioctl - so constants need to be different types for android and not android. |
richard-uk1
force-pushed
the
add_ioctl_constants
branch
from
7527f4b to
0a64d24
Compare
|
I don't understand the mips error |
|
Yeah the build failures are unrelated, and the constants for other platforms can be added in time (hard to do so without CI), thanks @derekdreery! I'll work on merging this with a few others all at once |
|
:D |
|
To link things up, landed in #134 |
danielverkamp
pushed a commit
to danielverkamp/libc
that referenced
this pull request
Apr 28, 2020
* avx: _mm256_movedup_pd * avx: _mm256_lddqu_si256 * avx: _mm256_rcp_ps * avx: _mm256_rsqrt_ps * avx: _mm256_unpackhi_pd * avx: _mm256_unpackhi_ps * avx: _mm256_unpacklo_pd, _mm256_unpacklo_ps * avx: _mm256_testz_si256 * avx: _mm256_testc_si256 * avx: _mm256_testz_pd * avx: _mm256_testc_pd * avx: _mm256_testnzc_pd * avx: _mm_testz_pd * avx: _mm_testc_pd * avx: _mm_testnzc_pd * avx: _mm256_testz_ps, _mm256_testc_ps, _mm256_testnzc_ps * avx: _mm_testz_ps, _mm_testc_ps, _mm_testnzc_ps * avx: _mm256_movemask_pd, _mm256_movemask_ps * avx: _mm256_setzero_pd, _mm256_setzero_ps * avx: _mm256_setzero_si256 * avx: _mm256_set_pd, _mm256_set_ps * avx: _mm256_set_epi8 * avx: _mm256_set_epi16 * avx: _mm256_set_epi32 * avx: _mm256_set_epi64x * avx: _mm256_setr_pd, _mm256_setr_ps * avx: _mm256_setr_epi8 * avx: _mm256_setr_epi16 * avx: _mm256_setr_epi32, _mm256_setr_epi64x * avx: add missing assert_instr * avx: _mm256_set1_pd * avx: _mm256_set1_ps * avx: _mm256_set1_epi8 * avx: _mm256_set1_epi16, _mm256_set1_epi32 * avx: _mm256_set1_epi64x * avx: _mm256_castpd_si256, _mm256_castsi256_pd, _mm256_castps256_ps128, _mm256_castpd256_pd128, _mm256_castsi256_si128 * avx: remove assert_instr failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some constants for ioctl calls.