-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose futimens and utimensat on FreeBSD and DragonFly #1085
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ |
📌 Commit 622cc28 has been approved by |
Expose futimens and utimensat on FreeBSD and DragonFly Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944). Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.
💔 Test failed - status-travis |
The two failures in the Travis build look like flakes due to a network download issue. What's the process here? I do not have the permissions to make Travis re-run those two failed builds. |
@bors: retry Ah we just try again! |
Expose futimens and utimensat on FreeBSD and DragonFly Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944). Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.
💔 Test failed - status-travis |
@bors: retry |
Expose futimens and utimensat on FreeBSD and DragonFly Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944). Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.
💔 Test failed - status-travis |
@bors: retry |
@jmmv: 🔑 Insufficient privileges: not in try users |
@bors: retry |
Expose futimens and utimensat on FreeBSD and DragonFly Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944). Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.
💔 Test failed - status-travis |
@bors: retry ??? |
Expose futimens and utimensat on FreeBSD and DragonFly Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944). Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.
💥 Test timed out |
This is unfortunate... |
One last attempt today maybe? :-P |
@bors: retry |
Expose futimens and utimensat on FreeBSD and DragonFly Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944). Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.
💔 Test failed - status-travis |
This is sad :( Wondering if it's possible to just hit retry on the individual Travis build failures in the hope that we can iterate faster and get the flakes through? Or maybe these builds should be marked non-fatal until they can be made to work again? |
Unfortunately our CI doesn't work by retrying individual builds, I'll need to allocate some time to investigate and try to fix these android builds |
Give it another try? I have created a test repository that downloads the problematic files on Travis, using the same settings as this project, and cannot reproduce it: https://travis-ci.org/jmmv/test/builds/434537625. So either something else is going on, or the problem has been resolved. |
@bors: retry Sure yeah, can always try that! |
Expose futimens and utimensat on FreeBSD and DragonFly Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944). Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.
☀️ Test successful - status-appveyor, status-travis |
Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944).
Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.