Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: borsh serde" #570

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

dzmitry-lahoda
Copy link
Contributor

Reverts #525

@kayabaNerve
Copy link

This doesn't update the Cargo.toml to remove the borsh feature/dependency from there.

@dzmitry-lahoda
Copy link
Contributor Author

Sorry, will revert. So weird how it happend. I pressed revert in GH on commit which did added both rust and toml changes.

@Amanieu
Copy link
Member

Amanieu commented Oct 10, 2024

Can you update this PR to also revert the changes in Cargo.toml?

We will likely release 0.16 after this is merged since this is a breaking change.

@Amanieu Amanieu mentioned this pull request Oct 10, 2024
@Amanieu
Copy link
Member

Amanieu commented Oct 12, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Oct 12, 2024

📌 Commit 5b8e6d5 has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 12, 2024

⌛ Testing commit 5b8e6d5 with merge 20170b8...

@bors
Copy link
Contributor

bors commented Oct 12, 2024

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 20170b8 to master...

@bors bors merged commit 20170b8 into rust-lang:master Oct 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants