Backport #357 for 0.12 #498
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 8, 2024
Closed
Member
|
Is this still needed now that tkaitchuck/aHash#201 is merged? |
Member
Author
|
Not really, could still be worth it since the ecosystem is not yet on newer hashbrown and personally I'd prefer the fix in 0.8, but I don't think it's worth the effort of a backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the ahash bump to 0.12 (#357). It shouldn't be merged, instead it should be put in a branch/tag and released with a version bump (happy to update this PR to include a version bump if desired)
#497 is this PR for 0.11
A bunch of crates out there still use hashbrown at this version (Often via
indexmap, still used by the wasmer ecosystem)It would be nice to get a backport release here. A lot of these dependencies are deep in deptrees and will take time to upgrade.
I also have tkaitchuck/aHash#202 open but it's unclear if that will land