Skip to content

Improving documentation. Part 2. #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 23, 2022
Merged

Improving documentation. Part 2. #331

merged 11 commits into from
May 23, 2022

Conversation

JustForFun88
Copy link
Contributor

@JustForFun88 JustForFun88 commented May 9, 2022 •
edited
Loading

Continuation of #328.
Close #337.

@JustForFun88 JustForFun88 changed the title Improving documentation. Part 2. [WIP] Improving documentation. Part 2. May 11, 2022
@JustForFun88 JustForFun88 mentioned this pull request May 12, 2022
Merged
@JustForFun88
Merge branch 'rust-lang:master' into update_hashbrown_doc_2
c074a1b
@JustForFun88
Adding some example and more.
e62a838 
Adding some example and correcting inconsistent "example" and "examples" in headers
@JustForFun88
Running fmt
24c1706
@Amanieu
Copy link
Member

Amanieu commented May 14, 2022

LGTM!

Can you add #[allow(unused_macro_rules)] to suppress the warning that is making CI fail? This warning was recently added to nightly Rust, which is why is it failing now.

@Amanieu
Copy link
Member

Amanieu commented May 16, 2022

@bors r+

@bors
Copy link
Contributor

bors commented May 16, 2022

📋 Looks like this PR is still in progress, ignoring approval.

Hint: Remove [WIP] from this PR's title when it is ready for review.

@JustForFun88
Copy link
Contributor Author

@bors r+

Sorry, I'm still working on it :-) I'm a little busy at work so I can't finish.

@JustForFun88 JustForFun88 mentioned this pull request May 18, 2022
Closed
@JustForFun88 JustForFun88 changed the title [WIP] Improving documentation. Part 2. Improving documentation. Part 2. May 18, 2022
@JustForFun88
Copy link
Contributor Author

Ready. I will continue to improve the documentation in another pull request.

@Amanieu
Copy link
Member

Amanieu commented May 23, 2022

@bors r+

@bors
Copy link
Contributor

bors commented May 23, 2022

📌 Commit eaa1eef has been approved by Amanieu

@bors
Copy link
Contributor

bors commented May 23, 2022

⌛ Testing commit eaa1eef with merge 3dbcdcc...

@bors
Copy link
Contributor

bors commented May 23, 2022

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 3dbcdcc to master...

@bors bors merged commit 3dbcdcc into rust-lang:master May 23, 2022
@JustForFun88 JustForFun88 deleted the update_hashbrown_doc_2 branch May 23, 2022 15:52
@JustForFun88 JustForFun88 mentioned this pull request Jun 4, 2022
Merged
bors added a commit that referenced this pull request Jun 10, 2022
@bors
Auto merge of #339 - JustForFun88:update_hashbrown_doc_3, r=Amanieu
decf995 
Improving documentation. Part 3.

Continuation of #328 and #331.

Also I made some changes in the previously added examples (made `compute_hash` generic and rename `compute_hash` to `make_hasher` in `insert_with_hasher example`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in RawOccupiedEntryMut::get_key_value
3 participants
@JustForFun88 @Amanieu @bors