Skip to content

Respect 'require_literal_leading_dot' option in 'glob_with' method for path components #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

kitogo
Copy link

@kitogo kitogo commented Mar 22, 2018

This fixes #67
Make sure to filter out folders that start with dot when filling todo if require_literal_leading_dot option is set.

@kitogo kitogo changed the title Resenc 'require_literal_leading_dot' option is not considered by 'glob_with' method for path components Respect 'require_literal_leading_dot' option is 'glob_with' method for path components Mar 22, 2018
@kitogo kitogo changed the title Respect 'require_literal_leading_dot' option is 'glob_with' method for path components Respect 'require_literal_leading_dot' option in 'glob_with' method for path components Mar 22, 2018
@abbec
Copy link

abbec commented May 4, 2018

Bump :)

@samuelallan72
Copy link

It would be nice to see this fix merged. It affects a project I'm building. :)

Happy to help maintain this crate if more bandwidth is required.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
I'm going to merge this as #128 because it needs a fix for the test and a rebase.

JohnTitor added a commit that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using 'require_literal_leading_dot' matches folders that start with dot
5 participants