Expose git_diff_blobs API #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, looks like I wrote my patches against alex's fork which is stale. I can rebase against the master, but would like feedback on the main approach first. |
In particular, this makes the file callback optional as well. It also renames the struct to be a bit less specific to the foreach method; the next patch will reuse this in a different API.
|
Patches rebased to master. |
|
Seems reasonable to me! Usage-wise a builder might be a bit more ergonomic than a many-argument-method, but I don't really have much of a preference one way or another. |
This could be improved by adding color support, etc.
|
Patches ready for review now. I ran rustfmt and modified the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
diff_blobsmethod on theRepositorywhich exposes thegit_diff_blobsAPI in libgit2. The patch should be functionally complete although I haven't tested it extensively. The example app changes could be improved, but I wanted to get some feedback first as to whether this patch would be acceptable or not, and if any more fundamental changes are needed.Thanks!